Fix output formatting differences between JRuby and Ruby when converting Float to JSON#936
Closed
evaniainbrooks wants to merge 1 commit into
Closed
Fix output formatting differences between JRuby and Ruby when converting Float to JSON#936evaniainbrooks wants to merge 1 commit into
evaniainbrooks wants to merge 1 commit into
Conversation
…ing Float to JSON
Author
|
It appears this needs to wait for a new version of JRuby 9.4 to be released. |
Contributor
|
We will need to patch this to use the old logic on older JRuby versions or it will break for users on any version other than 10.0.3.0. I will suggest a change. |
Author
|
@headius I don't mind following up on this again. If you have a moment, let me know what you want to see and I will give it a go.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue #817